XWIKI-22816: Icon and edit link aren't on the same line anymore when editing single object #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…editing single object * Updated the style of the `edit all objects` link to behave as expected. This means removing customizations that were made to fit a CSS only icon. * Added back a cross in the `remove deprecated property` link.
michitux
requested changes
Feb 5, 2025
| @@ -247,7 +247,11 @@ | |||
| #if ($mustSync) | |||
| <div class="box warningmessage deprecatedProperties"> | |||
| $services.localization.render('core.editors.object.removeDeprecatedProperties.all.info') | |||
| <div><a class="syncProperties syncAllProperties" href="$doc.getURL('objectsync')" title="$services.localization.render('core.editors.object.removeDeprecatedProperties.all.link.tooltip')">$services.localization.render('core.editors.object.removeDeprecatedProperties.all.link')</a></div> | |||
| <div><a class="syncProperties syncAllProperties" href="$doc.getURL('objectsync')" title="$services.localization | |||
| .render('core.editors.object.removeDeprecatedProperties.all.link.tooltip')"> | |||
There was a problem hiding this comment.
I've just tested this and this line break breaks the computation of the title of the link. Velocity doesn't support having line breaks in the middle of a call. You could move the line break before title=.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22816
Changes
Description
edit all objectslink to behave as expected. This means removing customizations that were made to fit a CSS only icon.remove deprecated propertylink.Screenshots & Video
See the ticket for the buggy looks of this UI before the changes proposed in this PR.
After the changes, here is what it looks like:
When hovered, the whole link gets its
:hoveredstyle: it's dark blue, and the FA cross takes the same color :)Executed Tests
None, minor change to the DOM (adding an icon), and CSS layout changes are not tested.
Successfully built the two modules with changes with the
qualityprofile :mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war -Pqualityandmvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources -Pquality.Expected merging strategy
XWIKI-21236: Object edit mode does not use current icon theme. It's a pretty safe backport.