XWIKI-11544: Impossible to access the drawer menu with javascript deactivated #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctivated * Added a media query to display the drawer even when javascript is deactivated.
…ctivated * Reverted unwanted changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-11544
Changes
Description
Clarifications
Screenshots & Video
After the PR:
Executed Tests
This is a style change only on a very specific context. We don't have automatic tests for this.
See the screenshot of a manual test on my local instance. In order to deactivate javascript in my Firefox, I used the
javascript.enabledadvanced parameter.Expected merging strategy