XWIKI-22782: Only save modified xobjects #3798
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michitux
reviewed
Jan 14, 2025
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseElement.java
Show resolved
Hide resolved
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseElement.java
Show resolved
Hide resolved
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseElement.java
Show resolved
Hide resolved
tmortagne
force-pushed
the
feature-deploy-xobjectdirty
branch
2 times, most recently
from
e13046d to
009d360
Compare
tmortagne
force-pushed
the
feature-deploy-xobjectdirty
branch
3 times, most recently
from
1b98e9e to
081a360
Compare
tmortagne
force-pushed
the
feature-deploy-xobjectdirty
branch
from
081a360 to
f1b0fa8
Compare
tmortagne
force-pushed
the
feature-deploy-xobjectdirty
branch
2 times, most recently
from
925a806 to
57a0528
Compare
tmortagne
force-pushed
the
feature-deploy-xobjectdirty
branch
from
57a0528 to
f5af05c
Compare
surli
reviewed
Feb 10, 2025
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java
Show resolved
Hide resolved
surli
reviewed
Feb 10, 2025
...orm-oldcore/src/main/java/com/xpn/xwiki/internal/store/hibernate/HibernateConfiguration.java
Show resolved
Hide resolved
tmortagne
force-pushed
the
feature-deploy-xobjectdirty
branch
3 times, most recently
from
e750d19 to
71756b8
Compare
tmortagne
force-pushed
the
feature-deploy-xobjectdirty
branch
from
71756b8 to
0587cb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22782
Changes
Description
Serializablecleanup (revapi was getting a bit lost). It's not even clear to me whyBaseElementand its derivatives areSerializablein the first place, but that's another story…Clarifications
The general idea is to try to reduce the useless requests during document save. This pull request is focusing in making sure we don't re-save xobject which are identical to what's in the database already.
The save side of things is the easy part, most of the changes in the pull request are about trying to make sure we properly track modifications made to objects.
To avoid problems with complex use cases, this optimization is only applied if the document
isChangeTracked()is true, and currently this is false by default and set to true only by the hibernate store when loading a document.Executed Tests
Counting on existing test to validate that at least there is no regression.
TODO: various unit tests to check the behavior of the new BaseObject (actually BaseElement, since BaseObject is not the only element with this concept) dirty flag.
Expected merging strategy