Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: createRunnableDevEnvironment returns RunnableDevEnvironment, not DevEnvironment #18673

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: createRunnableDevEnvironment returns RunnableDevEnvironment, not DevEnvironment #18673

merged 1 commit into from
Nov 15, 2024
+1 −1

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Nov 14, 2024 •
edited
Loading

Description

createRunnableDevEnvironment was returning incorrect type. DevEnvironment doesn't have a runner property 😄

@sapphi-red sapphi-red added feat: environment API Vite Environment API p3-minor-bug An edge case that only affects very specific usage (priority) has workaround p2-edge-case Bug, but has workaround or limited in scope (priority) and removed p3-minor-bug An edge case that only affects very specific usage (priority) labels Nov 15, 2024
@bluwy bluwy merged commit 74221c3 into vitejs:main Nov 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: environment API Vite Environment API has workaround p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheremet-va @bluwy @sapphi-red