feat: added option dataAttributeSalt to saltify data-attributes #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you are dealing with MFE and own ui-kit, you need the ability to use different version of ui-kit on different MFE's.
But on our project we encountered a problem: styles from diffrent version of ui-kit overwrite each other.
Additional context
We tried to use attribute
scoped
on styles, but it didn't help. This is because data-attributes are based on a hash of the component code and if the styles are in a separate file the hash doesn't change.The
dataAttributeSalt
option helps to provide a "salt" to a data-attribute which can contain any value you want (for example random value or version number).Therefore styles become unique throught the MFE even if they use different versions of ui-kit with different styles.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).