Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: single project changes #2325

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kunal22shah
Copy link
Contributor

@Kunal22shah Kunal22shah commented Jun 6, 2024

GitHub Issue (If applicable): closes #146

PR Type

  • Documentation content changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Kunal22shah Kunal22shah added the kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project label Jun 6, 2024
@Kunal22shah Kunal22shah self-assigned this Jun 6, 2024
@agneszitte
Copy link
Contributor

I will help to add additional screenshots for iOS/MacCatalyst

@Kunal22shah Kunal22shah marked this pull request as ready for review June 11, 2024 19:37
Co-authored-by: Steve Bilogan <[email protected]>
@Kunal22shah Kunal22shah requested a review from kazo0 June 17, 2024 18:26
Co-authored-by: Steve Bilogan <[email protected]>
@Kunal22shah Kunal22shah requested a review from kazo0 June 18, 2024 13:35
@@ -9,22 +9,64 @@ The controls from MauiCommunityToolkit can be used in an Uno Platform applicatio

An existing sample app that showcases the controls is available [here](https://github.com/unoplatform/Uno.Samples/tree/master/UI/MauiEmbedding/MauiCommunityToolkitApp).

> [!NOTE]
> MauiCommunityToolkitApp SDK for .NET is currently only compatible with Windows, Android, iOS, and Mac Catalyst when used with Uno Platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> MauiCommunityToolkitApp SDK for .NET is currently only compatible with Windows, Android, iOS, and Mac Catalyst when used with Uno Platform.
> .NET Maui Community Toolkit is currently only compatible with Windows, Android, iOS, and Mac Catalyst when used with the Uno Platform.

```
### [Visual Studio](#tab/vs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazo0 kazo0 marked this pull request as draft September 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes an issue or PR as relevant to 3rd party dependencies that are consumed by this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants