Updated infrastructure packages #2215
Conversation
xperiandri
force-pushed
the
infrastructure_packages_update
branch
from
e6ca3c2
to
7605dd1
Compare
|
@Youssef1313 can you check this PR and verify any changes to msbuild props |
| <PackageVersion Include="MSTest.TestAdapter" Version="2.2.9" /> | ||
| <PackageVersion Include="MSTest.TestFramework" Version="2.2.9" /> | ||
| <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" /> | ||
| <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.1.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0" /> | ||
| <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.9.2" /> |
There was a problem hiding this comment.
Why is this update needed?
It will require Visual Studio 17.9, so 17.8 and earlier will no longer be supported.
There was a problem hiding this comment.
I thought it just brings new code analysis features
There was a problem hiding this comment.
@xperiandri Nope, this has an impact on the minimum supported VS version
src/Directory.Packages.props
Outdated
| <PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.756" /> | ||
| <PackageVersion Include="Microsoft.WindowsAppSDK" Version="1.4.231219000" /> | ||
| <PackageVersion Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.22621.3233" /> | ||
| <PackageVersion Include="Microsoft.WindowsAppSDK" Version="1.5.240311000" /> |
There was a problem hiding this comment.
Not sure if we want to bump this for now. We had a discussion with @nickrandolph around some issues that are "partially" on WinUI side and are fixed in 1.5, but I'm not sure if we'll end up wanting to update or not.
| @@ -402,7 +402,9 @@ private bool GetIsDisabled(string propertyName) | |||
| } | |||
| using var resourceReader = new StreamReader(resource); | |||
|
|
|||
| #pragma warning disable RS1035 // Using Environment.NewLine is fine | |||
There was a problem hiding this comment.
Fine for now, but not yet clear if we should be using Environment.NewLine or not. There is a bit of discussion around that in dotnet/roslyn-analyzers#6467
xperiandri
force-pushed
the
infrastructure_packages_update
branch
from
7605dd1
to
8871a7e
Compare
xperiandri
force-pushed
the
infrastructure_packages_update
branch
from
8871a7e
to
8dc1a3a
Compare
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements: