-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dark mode support #701
base: master
Are you sure you want to change the base?
Conversation
Cancellation Tokens should be used to notify task to shut down instead of broadcast channels closes tokio-rs#694
How do I get my browser to switch to dark mode? |
@Darksonn If you "turn on" dark theme on your device, then website will also switch to dark mode |
@hawkw also checkout docs and code snippets |
Sure, this sounds good to me. I would be happy to merge this. Did you have any further changes you wanted to get in before I do so? |
@Darksonn let me add a button to toggle theme, then we can merge it |
Hey @Darksonn, You can review and merge this PR now if everything looks good |
I tried clicking the button on this page, but the area to the right of the page remains white. See the screenshot below. |
Bulma 1.0 has dark mode support built-in, but is a little complex to upgrade. See: |
Hello everyone,
I'm excited to share this PR for adding dark theme support. Please visit the preview, I would really appreciate your feedback and suggestions.
You can also suggest some better colors for the dark theme.
I'd also like to know if there are any UI elements where the dark theme changes have not been applied or any other feedback, I'm all ears.
Thank you so much for taking the time to review my PR and provide your insights. I look forward to hearing your thoughts!
Pending actions on this PR: