check size of arr before indexing into it #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors were detected when arr was undefined, and this code attempted to index arr[0], which of course produced an exception that caused jellyfish to restart, and customers reported 504 (gateway timeout) errors in that time. Apparently all of the jellyfish instances were rebooting, presumably do to this issue..? Slack link: https://tidepoolteam.slack.com/archives/C09AWCB4Y/p1709042338637789 Sumologic: https://service.us2.sumologic.com/ui/#/search/create?id=dC35xRBPVUhc23bvxpUEUqi8S0AujosStdg239RM
ewollesen
force-pushed
the
eric/undefined-array-indexing-fix
branch
from
f8c4200 to
faefeca
Compare
toddkazakov
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Please consider this just an rough attempt, proper investigation should be made. !!!
Errors were detected when arr was undefined, and this code attempted to index
arr[0], which of course produced an exception that caused jellyfish to
restart, and customers reported 504 (gateway timeout) errors in that
time. Apparently all of the jellyfish instances were rebooting, presumably do
to this issue..?
Slack link:
https://tidepoolteam.slack.com/archives/C09AWCB4Y/p1709042338637789
Sumologic: https://service.us2.sumologic.com/ui/#/search/create?id=dC35xRBPVUhc23bvxpUEUqi8S0AujosStdg239RM