feat: store panel open state in storage #641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyhw
reviewed
Nov 7, 2024
| @@ -0,0 +1,12 @@ | |||
| import { useEffect, useState } from 'react'; | |||
| import store from 'store2'; | |||
There was a problem hiding this comment.
I don't think this store actually works, I'm realising now that its in the lastViewed hook but I think its just an artifact from me copy/pasting a bit too freely from the web code 😅
We have the storage from the getStorybookUI thats required maybe we can pass that down to the ui
Edit:
Wait i guess if this is for web only that would work 🤔
There was a problem hiding this comment.
Yes it's only web, but I can take a look at the other storage solution and migrate to that so maybe we can drop store2 usage later alltogether.
There was a problem hiding this comment.
yeah the thing is that we also want tablets and other wide screen devices to work so that would be ideal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In my team we often don't use the addons panel actively, but it opens again everytime you refresh storybook in web.
What I did
I reused the storage solution from
lastViewedStoryIdswhich leveragesstore2and store the addons panel and sidebar open state in storage.