Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esm-shim): use mlly to find index to append shim #1844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

younggglcy
Copy link
Contributor

Rollup Plugin Name: {@rollup/plugin-esm-shim}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

This PR should resolve #1842

Description

  1. provide named esm export
  2. keep track with https://github.com/unjs/unbuild/blob/main/src/builders/rollup/plugins/cjs.ts, so findStaticImports is used to find index to append code shim, which is implemented with AST. The original ESMStaticImportRegex is dropped.

Copy link
Member

@tada5hi tada5hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@rollup/plugin-esm-shim] shim is inserted in wrong place
2 participants