-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_assert_model_version #325
fix_assert_model_version #325
Conversation
@grzegorz-roboflow , please review |
@venkatram-dev , thanks for addressing comments! I left one minor note. I will approve since the change makes sense to me, but since I'm not the main contributor it would be nice if either @probicheaux , @SolomonLake , @tonylampada or @iurisilvio would also approve :) |
@SolomonLake did changes related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
A future improvement would pulling this duplicated code w/ init
into a shared method that loads a model based on type.
Thank you for your contribution @venkatram-dev, and above all thank you for your patience! |
Description
Please include a summary of the change and which issue is fixed or implemented. Please also include relevant motivation and context (e.g. links, docs, tickets etc.).
Fixes this issue
#314
Steps to reproduce
From the UI, Created a new project, new version with sample dataset, created version.
Ran the training code.
Getting error
List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested in my local
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs