Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break requirements.txt into environment specific modules #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

birdcar
Copy link
Collaborator

@birdcar birdcar commented May 16, 2021

Our previous approach to dependencies was creating a high barrier to entry for new contributors (and new Pythonistas/Djangonauts) since it required them to have a production environment installed locally just to install the requirements files.

This change moves production-specific dependencies to a separate module, simplifies local setup, and opens the possiblity of having development specific dependencies in the future.

closes #37

Our previous approach to dependencies was creating a high barrier to
entry for new contributors (and new Pythonistas/Djangonauts) since
it required them to have a production environment installed locally
just to install the requirements files.

This change moves production-specific dependencies to a separate
module, simplifies local setup, and opens the possiblity of having
development specific dependencies in the future.

closes psf#37
@birdcar
Copy link
Collaborator Author

birdcar commented May 16, 2021

@meg-ray We'll definitely want someone to look over the dependency cleanup I did 👀

The direct dependency list was put together after reading through the code that we're importing and also by using pipdeptree. I ran the application locally and everything appeared to work, but since this is my first time using the application I'm not certain exactly what "everything" or "work" means haha.

As long as the list appears to check out then I think we're good to go on this!

@meg-ray
Copy link
Contributor

meg-ray commented May 16, 2021

I am going to test this by re-creating my dev environment, so it may take me a bit to merge. When you ran it locally, did you test the forums? Spirit has a ton of requirements.

@birdcar
Copy link
Collaborator Author

birdcar commented May 16, 2021

@meg-ray I clicked around the forums, but didn't specifically test any functionality. Having said that, when I checked the packages output by pip freeze they still matched everything that was in the original requirements.txt file, so I think we're good there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up requirements and verify direct project dependencies
2 participants