-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update label to identify number of pods #648
Update label to identify number of pods #648
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -144,7 +144,7 @@ func GetQueueJobKey(obj interface{}) (string, error) { | |||
// UpdateQueueJobStatus was part of pod informer, this is now a method of queuejob_controller file. | |||
// This change is done in an effort to simplify the controller and enable to move to controller runtime. | |||
func (qjm *XController) UpdateQueueJobStatus(queuejob *arbv1.AppWrapper) error { | |||
labelSelector := fmt.Sprintf("%s=%s", "appwrapper.mcad.ibm.com", queuejob.Name) | |||
labelSelector := fmt.Sprintf("%s=%s", "ray.io/cluster", queuejob.Name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks suspicious.
Why would MCAD label pod using Ray label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. @ChristianZaccaria this probably works for your particular use case, but that mechanism must be generic, for whatever resources managed by the AppWrapper. So the root cause is likely a missing update of these managed resources, so they are labeled with appwrapper.mcad.ibm.com
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that makes sense now. The managed resources are not updating their labels to use appwrapper.mcad.ibm.com
. So, are we speaking about a bug issue, or is this something just happening on my end? (I suppose in any case, we could probably close this issue). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very possible it's a bug. One possibility is that controller owning the resource / generic item overwrites the label applied by MCAD.
Closing PR. Issue #646 has been updated to reflect what has been discussed here. |
Issue link
What changes have been made
Updated label selector.
Verification steps
There are
.Checks