-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Dropdown to Remain Open for multi==True
#2821
base: dev
Are you sure you want to change the base?
Conversation
On second thought, it would make more sense to not write over the |
@@ -155,6 +157,7 @@ const Dropdown = props => { | |||
filterOptions={filterOptions} | |||
options={sanitizedOptions} | |||
value={value} | |||
closeOnSelect={multi ? close_on_select : true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, it would make more sense to not write over the
close_on_select
prop. If someone were to change multi, the prop would be lost and it would always close.
👍
@T4rk1n I’m willing to help out for this request. Is there something that still needs to be done? Probably the docs need to be updated for the new parameter but this doesn’t seem to be open source |
@WWakker Just need to change this: |
multi==True
multi==True
Closes #2820 (and #2669, an earlier report of the same issue). This PR adds the ability to set the prop
close_on_select
. Ifmulti
isTrue
and this prop isFalse
, the menu selection remains open. If this new prop isTrue
, it is the same behavior. Theclose_on_select
prop has no effect whenmulti
isFalse
, it well essentially ignore the value. I did it that way, as I don't see the value changing after the component is created, similar tomulti
.This PR will probably have a need to update the dash docs for the dropdown.
Contributor Checklist
close_on_select
to the dropdown componentoptionals
CHANGELOG.md