riscv64: Fix link error about relocation #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With GNU ld v2.42, the integer.c and compressed.c build fail with error: "dangerous relocation: The addend isn't allowed for R_RISCV_GOT_HI20" for JMP_RANGE related test cases. This patch changes the target addr loading to local addr loading, thus to avoid the unnecessary global symbol relocation. Though currently there's no "1f+x" style addr loading for rs2, this patch changes it together with rs1. Signed-off-by: Xiao Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GNU ld v2.42, the integer.c and compressed.c build fail with error: "dangerous relocation: The addend isn't allowed for R_RISCV_GOT_HI20" for JMP_RANGE related test cases.
This patch changes the target addr loading to local addr loading, thus to avoid the unnecessary global symbol relocation.
Though currently there's no "1f+x" style addr loading for rs2, this patch changes it together with rs1.