TDRD-229 - Add skipValidation flag in addOrUpdateBulkFileMetadata mutation #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kip-validation # Conflicts: # src/main/scala/uk/gov/nationalarchives/tdr/api/metadatainputvalidation/MetadataInputTags.scala
TomJKing
reviewed
Jan 29, 2025
| @@ -33,6 +34,34 @@ class ValidateFileMetadataService( | |||
| }) | |||
| } | |||
|
|
|||
| def addAdditionalMetadataStatuses(fileMetadataList: Seq[AddOrUpdateFileMetadata]): Future[Seq[FilestatusRow]] = { | |||
There was a problem hiding this comment.
Should move this method to the FileStatusService class
The helper methods: toPropertyNames; toAdditionalMetadataFieldGroups; toValueDependenciesGroups should be moved to the CustomMetadataPropertiesService
src/main/scala/uk/gov/nationalarchives/tdr/api/service/FileMetadataService.scala
Outdated
Show resolved
Hide resolved
Do not allow a user to skip the validation if the user doesn't have update_metadata access
TomJKing
reviewed
Jan 31, 2025
src/main/scala/uk/gov/nationalarchives/tdr/api/service/CustomMetadataPropertiesService.scala
Show resolved
Hide resolved
src/main/scala/uk/gov/nationalarchives/tdr/api/service/FileStatusService.scala
Outdated
Show resolved
Hide resolved
src/main/scala/uk/gov/nationalarchives/tdr/api/service/ValidateFileMetadataService.scala
Outdated
Show resolved
Hide resolved
src/test/scala/uk/gov/nationalarchives/tdr/api/routes/FileMetadataRouteSpec.scala
Show resolved
Hide resolved
src/main/scala/uk/gov/nationalarchives/tdr/api/service/ValidateFileMetadataService.scala
Outdated
Show resolved
Hide resolved
src/main/scala/uk/gov/nationalarchives/tdr/api/graphql/fields/FileMetadataFields.scala
Show resolved
Hide resolved
...test/scala/uk/gov/nationalarchives/tdr/api/service/CustomMetadataPropertiesServiceSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/uk/gov/nationalarchives/tdr/api/service/FileServiceSpec.scala
Show resolved
Hide resolved
src/test/scala/uk/gov/nationalarchives/tdr/api/service/FileStatusServiceSpec.scala
Show resolved
Hide resolved
src/test/scala/uk/gov/nationalarchives/tdr/api/service/ValidateFileMetadataServiceSpec.scala
Show resolved
Hide resolved
TomJKing
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.