Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local API tests #1792

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Fix local API tests #1792

merged 5 commits into from
Feb 3, 2025

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented Feb 3, 2025

About these changes

Fixed API tests on the local machine, where no WAGTAILAPI_BASE_URL was being set on Github.

This now uses the value of WAGTAILAPI_BASE_URL so that detail_url is no longer environment/device dependent.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs merged commit cee2a9d into develop Feb 3, 2025
6 checks passed
@jamesbiggs jamesbiggs deleted the fix/api-tests branch February 3, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant