Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an IChatClient implementation to OnnxRuntimeGenAI #987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add an IChatClient implementation to OnnxRuntimeGenAI #987

wants to merge 1 commit into from

Conversation

stephentoub
Copy link
Member

No description provided.

nmetulev
nmetulev reviewed Oct 29, 2024
View reviewed changes
src/csharp/ChatClient.cs Outdated Show resolved Hide resolved
azchohfi
azchohfi reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@azchohfi azchohfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then only issue I found is that when ChatOptions is null, it fails for Phi 3.5. This works fine for Phi3.
Phi 3.5 requires max_length to be provided. Seems to be a bug on Phi3.5, but I do not see a way around it, other than always providing max_length.

@natke
Copy link
Contributor

natke commented Nov 5, 2024

@stephentoub can you please merge main into your branch? This should enable the CIs to pass

@stephentoub
Copy link
Member Author

@stephentoub can you please merge main into your branch? This should enable the CIs to pass

Thanks, but it's already based off of the latest commit in main. It seems like whatever feed is being used may not contain some of the necessary packages, like System.Text.Json?

@pranavsharma
Copy link
Contributor

Can you add a test?

@azchohfi
Copy link
Contributor

@pranavsharma Seems like the package needs to be added to the feed, from the upstream (nuget.org).

@stephentoub
Copy link
Member Author

Can you add a test?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmetulev nmetulev nmetulev left review comments

@azchohfi azchohfi azchohfi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephentoub @natke @pranavsharma @azchohfi @nmetulev