Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch ort exception when trying to allocate key value cache #1058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

baijumeswani
Copy link
Contributor

Addresses #980

Copy link
Member

@RyanUnderhill RyanUnderhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff in github looks bigger than it really is due to the indents?

Since it looks like it's just adding the try/catch unless I'm missing something.

@baijumeswani
Copy link
Contributor Author

Yes, the indents make it look bigger than it really is.

@f2bo
Copy link

f2bo commented Nov 15, 2024

Hi. I originally reported #980. While the updated error message is better, it doesn't identify the root cause unless you are familiar with the runtime's internals, especially when raised following a call to a higher level component. Perhaps, it would be more actionable if it made the association with the 'max_length' option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants