Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stdint import to build on g++13 #576

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

MRandl
Copy link

@MRandl MRandl commented Aug 12, 2024

  • [yes] Does this PR have a descriptive title that could go in our release notes?
  • [no] Does this PR add any new dependencies?
  • [no] Does this PR modify any existing APIs?
  • [no] Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues

Fixes #570

What does this implement/fix? Briefly explain your changes.

ann_exception.h contained a reference to the type uint32_t, which is imported implicitly by g++9 but not g++13, resulting in build failure.
We patch this by explicitly including stdint.h (and not cstdint, to avoid changing the namespace in the signatures, upon which some people might depend)

@MRandl
Copy link
Author

MRandl commented Aug 12, 2024

@microsoft-github-policy-service agree company="EPFL"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Build fails on g++ >= 13
1 participant