Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditionalAccessGapAnalyzer.workbook #2418

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Palciny
Copy link

@Palciny Palciny commented Sep 11, 2023

conditionalAccessGapAnalyzer.workbook is including "Windows SignIn" that doesn't support MFA, so it doesn't have sense to be included in the report.

There was also request for this change:

#1824

PR Checklist

  • Explain your changes, so people looking at the PR know what and why, the code changes are the how.
  • Validate your changes using one or more of the testing methods.

If adding or updating templates:

  • post a screenshot of templates and/or gallery changes
  • ensure your template has a corresponding gallery entry in the gallery folder
  • If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
  • ensure all steps have meaningful names
  • ensure all parameters and grid columns have display names set so they can be localized
  • ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
  • ensure that steps names are unique or they will fail PR validation (step names are used for localization)
  • grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
  • remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

conditionalAccessGapAnalyzer.workbook is including "Windows SignIn" that doesn't support MFA, so it doesn't have sense to be included in the report.

There was also request for this change: 

microsoft#1824
@Palciny Palciny requested a review from a team as a code owner September 11, 2023 08:57
@Palciny
Copy link
Author

Palciny commented Sep 11, 2023

@sabinasmith can you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant