Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ArchUnit tests #3778

Merged
merged 27 commits into from
Jan 17, 2025
Merged

Fixed ArchUnit tests #3778

merged 27 commits into from
Jan 17, 2025

Conversation

lorriborri
Copy link
Member

@lorriborri lorriborri marked this pull request as ready for review January 8, 2025 13:55
@lorriborri lorriborri requested a review from hamidonos January 8, 2025 13:56
hamidonos
hamidonos requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@hamidonos hamidonos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new rules for test classes. Good job 👍

But I'd like you to have a look at my comments:

You are mixing // ... and /* ... */ style of comments
Please use /* ... */ for real comments

I don't see a reason to put a generic warning message behind specific ArchUnit rules (because(...)). Either check for the violations at the end or print a generic warning message at the start/end.

I did not look at every violation here but please make sure that every test class ends with Test and any supporting test class starts with Test. Nothing in between should be possible.

Moving from assertEquals to fluent AssertJ ist optional. But it is beneficial in the long run.

sechub-archunit-test/src/test/java/mercedesbenz/com/sechub/archunit/ArchUnitRuntimeSupport.java Outdated Show resolved Hide resolved
...test/java/com/mercedesbenz/sechub/commons/core/resilience/ResilientRunnableExecutorTest.java Outdated Show resolved Hide resolved
...test/java/com/mercedesbenz/sechub/commons/core/resilience/ResilientRunnableExecutorTest.java Outdated Show resolved Hide resolved
sechub-archunit-test/src/test/java/mercedesbenz/com/sechub/archunit/NamingConventionTest.java Show resolved Hide resolved
sechub-doc/src/test/java/com/mercedesbenz/sechub/PDSDataExampleTestFile.java Outdated Show resolved Hide resolved
...red-kernel/src/test/java/com/mercedesbenz/sechub/sharedkernel/monitoring/TestCPUMonitor.java Outdated Show resolved Hide resolved
@lorriborri lorriborri requested a review from hamidonos January 13, 2025 13:21
lorriborri and others added 4 commits January 14, 2025 15:52
@lorriborri
Refactored dependency and new naming convention rule #3713
2a0d198
@lorriborri
applied spotless #3713
dade353
@lorriborri
Refactored import and message on fail #3713
160ce13
@de-jcup
Native IDE builds and gradle builds do now work together #3713
8613b4c 
- eclipse and IntelliJ direct class builds can now used
  in parallel of gradle builds. Per default the arch unit tests
  will only test gradle build outputs. But by setting
  -Dsechub.archunit.ignoreFolders=build it is possible to
  execute arch unit tests directly inside IDE without gradle
hamidonos and others added 12 commits January 17, 2025 09:00
@hamidonos @lorriborri
Update spring boot version to 3.3.5 #3544 (#3615)
e17ac34 
* update spring boot version to 3.3.5 #3544

* added additional dependency org.flywaydb:flyway-database-postgresql to make flyway 10.10.0 and postgres 15.6 compatible
@lorriborri
Start a scan via web UI (#3767)
7a77257 
* Restructured pages and added create scan component #1900
* Added buttons and file input #1900
* Create configuration from user input #1900
* Added scan function and data upload api for source code and binaries #1900
* Added test setup #1900
* Added encryption ENV to docker images (local), refactored code #1900
@dependabot @lorriborri
Bump peter-evans/create-pull-request from 7.0.5 to 7.0.6
e7d41df 
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.5 to 7.0.6.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@5e91468...67ccf78)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@sven-dmlr @lorriborri
added security section to Helm chart #3779
6eb94e9
@sven-dmlr @lorriborri
adapted variable names in Helm chart #3779
a983856
@sven-dmlr @lorriborri
PR suggestion added #3779
17eefdc
@de-jcup @lorriborri
Changed ordering of cancel and ok button #3781
5eb5d0a
@sven-dmlr @lorriborri
server access from web-ui enabled #3786
23c119f
@sven-dmlr @lorriborri
SPDX headers added by SecHub release job @github-actions
425823c
@sven-dmlr @lorriborri
release wf fixed #3793
39c3a60 
also added updated .ts files
@sven-dmlr @lorriborri
SPDX headers added by SecHub release job @github-actions
b925b56
@hamidonos @lorriborri
implement job report download in web ui #3557 (#3806)
a174cd2 
* implement job report download in web ui #3557

* pr fixes #3557

* pr fixes #3557
winzj and others added 4 commits January 17, 2025 09:00
@winzj @lorriborri
Explicitly set geckodriver system property #3800
a70efe5
@lorriborri
Feature 3789 user can cancel job (#3799)
6b8f419 
* Added REST API for user cancel job #3789

* Applied spotless #3789

* Added 404 to openapi and replaced notauthorized by notfound #3789

* Added change requests #3789

* Added 204 to restDoc test #3789

* Added new management URL #3789

* Handle nullpointer #3789

* Refactored exception #3789

* Changed API URL #3789
@lorriborri
fixed imports #3713
8d869bf
@lorriborri
Merge branch 'develop' into feature-3713-fix-arch-unit-tests
94648fe
@de-jcup de-jcup self-requested a review January 17, 2025 08:38
de-jcup
de-jcup approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lorriborri lorriborri merged commit 0d87d28 into develop Jan 17, 2025
2 checks passed
@lorriborri lorriborri deleted the feature-3713-fix-arch-unit-tests branch January 17, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamidonos hamidonos hamidonos approved these changes

@de-jcup de-jcup de-jcup approved these changes

Assignees

@de-jcup de-jcup

@lorriborri lorriborri

@hamidonos hamidonos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArchUnit refactore code, fix tests and test imports
5 participants
@lorriborri @de-jcup @hamidonos @sven-dmlr @winzj