Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pricing list reuseable workflow call #5919

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

SAHU-01
Copy link

@SAHU-01 SAHU-01 commented Sep 23, 2024

Description

This PR adds a pricing list to layer5io and the data is populated by a workflow.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@vishalvivekm
Copy link
Member

@SAHU-01
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Sep 23, 2024

🚀 Preview for commit 0e0d317 at: https://66f1456cbbdedfda387ac2bb--layer5.netlify.app

@@ -0,0 +1,21 @@
name: Trigger Pricing List Workflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's refer to this as a features list, please (in the filename, too).

const summary = data
.filter(
(item) =>
item.entire_row["Subscription Tier"] === tierName &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm that there is a comment in the spreadsheet on this cell letting people know where to update feature list workflows if they change the column name.

@l5io
Copy link
Contributor

l5io commented Nov 8, 2024

🚀 Preview for commit f0214ad at: https://672dc88c826e4519b1aede45--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 8, 2024

🚀 Preview for commit 468751f at: https://672dd2fe5df160246cdc924c--layer5.netlify.app

Signed-off-by: Ankita Sahu <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 15, 2024

🚀 Preview for commit 06bf498 at: https://6736c37c2072aeffdd838bfe--layer5.netlify.app

@sudhanshutech
Copy link
Member

did you incorporated coming soon? @SAHU-01

@sudhanshutech
Copy link
Member

@jerensl workflow looks good?

@SAHU-01
Copy link
Author

SAHU-01 commented Nov 15, 2024

did you incorporated coming soon? @SAHU-01

Yes @sudhanshutech the logic is there, in the json file if you add Team-Beta to any of the entries subscription tier you'll see the coming soon appears

@l5io
Copy link
Contributor

l5io commented Nov 15, 2024

🚀 Preview for commit 661ca03 at: https://6736e730171fe5103fd8a52d--layer5.netlify.app

commit_options: "--signoff"
commit_user_name: l5io
commit_user_email: [email protected]
commit_author: ${{ github.actor }} <${{ github.actor }}@users.noreply.github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This github.actor is fragile, sometimes it willl refer to the person who merge this PR

Copy link
Author

@SAHU-01 SAHU-01 Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What possible fix would you suggest for this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

6 participants