-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement set pricing options at global_setting #418
base: development
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThe PR adds a new decimal field to the global settings form to allow setting a ticket fee percentage. The implementation extends the existing form fields using an OrderedDict to maintain field order. Class diagram for updated global settings formclassDiagram
class GlobalSettingsForm {
+DecimalField ticket_fee_percentage
}
note for GlobalSettingsForm "A new field 'ticket_fee_percentage' has been added to set a percentage fee for each ticket sold."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @odkhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR related to issue #381
New Features: