Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable use-any rule from revive #19120

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 1, 2025

Description

enable use-any rule from revive

Also sort revive rules alphabetically

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (f307354) to head (ea50139).
Report is 65 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.43% <100.00%> (ø)

... and 31 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19120      +/-   ##
==========================================
+ Coverage   68.79%   68.84%   +0.04%     
==========================================
  Files         420      420              
  Lines       35640    35649       +9     
==========================================
+ Hits        24520    24541      +21     
+ Misses       9696     9686      -10     
+ Partials     1424     1422       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f307354...ea50139. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Jan 9, 2025

enable use-any rule from revive

Let's try not overdo this. There are huge numbers of interface{} in the repo.

Also sort revive rules alphabetically

Looks good.

@mmorel-35
Copy link
Contributor Author

@ahrtr ,
What do you mean by huge number ?
They are only three before this.

@ahrtr
Copy link
Member

ahrtr commented Jan 9, 2025

What do you mean by huge number ?

Search interface{} in the repo. But most of them come from .pb.go files. So have we ignored those files in linter checks?

@mmorel-35
Copy link
Contributor Author

Yes by default golangci lint is not applied on generated files so this PR is already complete and won't require other changes

@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive/use-any branch from ae6749c to ea50139 Compare January 9, 2025 21:39
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jan 9, 2025
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mmorel-35

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 2dbb689 into etcd-io:main Jan 15, 2025
35 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/revive/use-any branch January 15, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants