Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) maps timeout for gitlab #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(feat) maps timeout for gitlab #164

wants to merge 1 commit into from

Conversation

eoinmcafee00
Copy link
Contributor

No description provided.

@eoinmcafee00 eoinmcafee00 added the gitlab GitLab conversion target label Aug 3, 2023
@eoinmcafee00 eoinmcafee00 changed the title gitlab conversion logic for timeout. (feat) maps timeout for gitlab Aug 3, 2023
@jimsheldon
Copy link
Contributor

Let's see if we can use https://github.com/tj/go-naturaldate in this logic

@jimsheldon
Copy link
Contributor

Let's see if we can use https://github.com/tj/go-naturaldate in this logic

I don't think we can use this package. It returns time.Time which is an instant in time, not a measure of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradrydzewski bradrydzewski Awaiting requested review from bradrydzewski

@jimsheldon jimsheldon Awaiting requested review from jimsheldon

Assignees
No one assigned
Labels
gitlab GitLab conversion target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eoinmcafee00 @jimsheldon