Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against multiple registrations #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guard against multiple registrations #297

wants to merge 1 commit into from

Conversation

koddsson
Copy link
Member

This will be required once chaijs/chai#1617 is merged and released.

@koddsson koddsson requested a review from 43081j May 16, 2024 13:30
43081j
43081j approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. could we maybe add a test too? 👀

calling use twice and ensuring a spy or something gets called once

dont worry if its a pain to spy on that stuff though, its a pretty obvious change we know will work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @43081j