Use scikit-build #673
Draft
Use scikit-build #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
build
branch
2 times, most recently
from
a73f4f0
to
638c30d
Compare
godlygeek
reviewed
Sep 7, 2024
godlygeek
force-pushed
the
build
branch
8 times, most recently
from
8d36fd5
to
6f80f8d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
+ Coverage 92.74% 93.54% +0.79%
==========================================
Files 95 97 +2
Lines 11475 11558 +83
Branches 2114 2114
==========================================
+ Hits 10643 10812 +169
+ Misses 832 746 -86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
godlygeek
force-pushed
the
build
branch
3 times, most recently
from
4dd729a
to
73cd67e
Compare
Signed-off-by: Pablo Galindo <[email protected]>
These environment variables previously allowed us to conditionally enable extra safety checks in our Cython code, or conditionally disable optimizations that might break tools like Valgrind. Now, we control this based on the CMake build type, so that release builds have the extra optimizations and debug builds don't, and so that debug builds have the extra safety checks and release builds don't. Signed-off-by: Matt Wozniski <[email protected]>
Some tests were erroneously removing all environment variables from the environment and passing along an environment consisting of only a single variable. Since this removes environment variables like $PATH, this breaks automatic rebuilds -- they can't find the compiler! Signed-off-by: Matt Wozniski <[email protected]>
This test failed in CI because the same time was captured in both `end_time` and `start_time`. There's no reason to assume that this took more than a millisecond, or that the system clock can give us better than millisecond granularity, so it seems more reasonable to simply check that the end time is no earlier than the start time. Technically even that assumption could be violated, since we're not using a monotonic clock, but oh well, this is just tests. Signed-off-by: Matt Wozniski <[email protected]>
We meant to ignore any Makefile generated by CMake, but we shouldn't be ignoring our own hand-written Makefile. Signed-off-by: Matt Wozniski <[email protected]>
`setuptools` uses CFLAGS for both C and C++ builds, but CMake distinguishes between them, and only uses CXXFLAGS for C++ builds. Whenever we want to set flags that affect both C and C++ builds, ensure that we set both CFLAGS and CXXFLAGS. Signed-off-by: Matt Wozniski <[email protected]>
With `scikit-build-core`, we don't have any way to produce an entry point script called `memray3.N` (where `3.N` is the Python version Memray was installed for). Drop references to it from the docs. Signed-off-by: Matt Wozniski <[email protected]>
With an editable `scikit-build-core` install, shared libraries are not in the same directory as Python files, so we can no longer locate it relative to `__init__.py`. Signed-off-by: Matt Wozniski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.