Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): default unknown TC lid state to closed #16838

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

ncdiehl11
Copy link
Collaborator

Overview

Latest designs specify that the thermocycler lid position should be default to closed at the Protocol Steps tab (all upstream steps of the first thermocycler step).

reference

Test Plan and Hands on Testing

  • create or upload a protocol that uses a Thermocycler
  • edit protocol and navigate to protocol steps tab— the thermocycler is now defaulted to the closed svg

Changelog

  • default null thermocycler lid state to 'closed'

Review requests

see test plan

Risk assessment

low

Latest designs specify that the thermocycler lid position should be default to closed at the
Protocol Steps tab (all upstream steps of the first thermocycler step).
@ncdiehl11 ncdiehl11 self-assigned this Nov 14, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 14, 2024 20:19
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 14, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant