fix(api): account for old plate reader serial format when parsing the device info.

[vegano1]

Overview

The RMA plate reader we just got back from byonoy has the old serial format in their eeprom, so we can't parse the serial number correctly, leading to issues addressing the device. Let's change the serial parsing to account for this, so we can continue to use the old byonoy devices.

Test Plan and Hands on Testing

• Make sure new and old format is parsed correctly
• Make sure you can update the fw on plate readers with new/old formatted serial
• Make sure the parsing works with the latest PVT plate readers

Changelog

• use match instead of fullmatch when parsing the plate reader serial number to account for old format

Review requests

Risk assessment

low, unreleased

[SyntaxColoring]

What exactly is the old format that the fullmatch doesn't match? Just extra whitespace around the serial number or something?

Because if it's actual "content," like XYZBYOABC123 instead of BYOABC123, that seems like something that we should capture in the regex instead of discarding it.

[vegano1]

What exactly is the old format that the fullmatch doesn't match? Just extra whitespace around the serial number or something?

unfortunely its more annoying than that

New format: BYOMAA00013
Old format: BYOMAA00040 REF: DE MAA 001

[SyntaxColoring]

Haha oof. Okay, yeah, this makes sense. Though, can we either add:

• Tests covering all the formats that we're trying to handle
• Or a comment next to SERIAL_PARSER giving examples of all the formats that we're trying to handle

[vegano1]

Never mind, there's a deeper issue that I'll need to look into.
The version format is also different now, ill re-open this pr when ready.

[vegano1]

I'm re-opening this to at least fix the serial number parsing.
There will be a separate pr to fix the versioning once we get word from the OEM.