feat(api): implement loadLiquidClass command in PE #16814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the second half of AUTH-851.
This implements the
loadLiquidClass()
command using the liquid class store from the previous PR.Liquid classes are read-only in the Protocol Engine, so each
liquidClassId
refers to one specific liquid class definition. Each mutation of a liquid class needs to be stored under a differentliquidClassId
. The caller can specify theliquidClassId
if they want to, or else we will generate one for them.So there are 4 cases we need to handle:
liquidClassId
and the liquid class is new: Generate a newliquidClassId
.liquidClassId
but the liquid class has already been stored: Reuse the existingliquidClassId
.liquidClassId
that we haven't seen before: Store the liquid class under the newliquidClassId
.liquidClassId
that's already been loaded: Check that the incoming liquid class matches the one we previously stored, and:Test Plan and Hands on Testing
I added 5 test cases to cover each of the scenarios above.
Review requests
Could someone teach me what
StateView.get_summary()
is supposed to do?Risk assessment
Low risk, liquid classes are not released yet and these changes should be dev-only. This change makes the Protocol Engine state marginally larger.