Dark mode Implimentation for Desktop #1169
Conversation
|
Hi @jgadsden sir, |
|
Hello @Shubham-Patel07 , thanks for the start on this feature, marking this draft because it is a work in progress |
|
I agree @Shubham-Patel07 there are still many views that need dark-mode applied |
|
Hi @jgadsden sir, |
|
Hi @jgadsden sir, |
| @@ -1,9 +1,18 @@ | |||
| const { contextBridge, ipcRenderer } = require('electron') | |||
| console.log('Preload script loaded2'); | |||
There was a problem hiding this comment.
not sure if this is intended to be left in, or if it is temporary debug?
| <b-button size="sm" variant="outline-light" @click="handleToggleDarkMode">Toggle Dark Mode</b-button> | ||
| </b-nav-item> | ||
| <b-nav-item> | ||
| <b-button size="sm" variant="outline-light" @click="handleSetSystemTheme">System Theme</b-button> |
There was a problem hiding this comment.
is this 'set system theme' needed? there is the dark mode toggle, which will provide the system theme when off
There was a problem hiding this comment.
this is an excellent enhancement to Threat Dragon, many thanks @Shubham-Patel07
Could you consider these suggestions:
- use of an icon instead of a button for the dark mode toggle, perhaps fa-solid fa-circle-half-stroke ? This would then need a tool tip in a similar way to the other nav bar icons
- could the system theme functionality be removed? It is in effect a duplication of dark mode toggle being in the off position
- could you provide a unit test for this in file
td.vue/tests/unit/components/navbar.spec.js
What kind of changes does this PR include?
Description
I have Implemented the dark mode for desktop
Relations
Closes #404
Checklist: