Port MASTG-TEST-0052 (by @guardsquare) #3045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpholguera
requested changes
Jan 30, 2025
|
|
||
| ## Steps | ||
|
|
||
| 1. Run a static analysis (e.g. @MASTG-TOOL-0073) on the app binary, or use @MASTG-TOOL-0038 to dynamically verify the properties of the keychain items during the app runtime. |
There was a problem hiding this comment.
This test needs to be split into static and dynamic
There was a problem hiding this comment.
This test still has something fundamental that we need to capture in a new test (or two): the app uses the Keychain API in 2 ways
- to store data in the Keychain itself (the keychain wasn't designed for this but developers do it)
- to encrypt data using keys from the Keychain and store it in private storage (envelope encryption)
|
|
||
| 1. Run a static analysis tool such as @MASTG-TOOL-0073 on the app binary. | ||
|
|
||
| 2. Search for APIs that indicates a use of Private Storage. This API includes: |
There was a problem hiding this comment.
I think we should add the use of encryption APIs for envelope encryption or the explicit use of insecure data protection classes (?)
cpholguera
reviewed
Jan 30, 2025
| @@ -0,0 +1,31 @@ | |||
| --- | |||
| platform: ios | |||
| title: Data Stored in Private Storage - Content Comparison Test | |||
There was a problem hiding this comment.
The Android test is called "Data Stored in the App Sandbox at Runtime" but we can discuss the naming. This test doesn't match the pattern we defined for dynamic tests: "Runtime Use …", It could be "Runtime Storage of ..." but let me know what you think please.
cpholguera
reviewed
Jan 30, 2025
Comment on lines
+19
to
+22
| - [UserDefaults](https://developer.apple.com/documentation/foundation/userdefaults) | ||
| - [documentDirectory](https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/documentdirectory) | ||
| - [applicationSupportDirectory](https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/applicationsupportdirectory) | ||
| - [userDomainMask](https://developer.apple.com/documentation/foundation/filemanager/searchpathdomainmask/1408037-userdomainmask) |
There was a problem hiding this comment.
Suggested change
| - [UserDefaults](https://developer.apple.com/documentation/foundation/userdefaults) | |
| - [documentDirectory](https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/documentdirectory) | |
| - [applicationSupportDirectory](https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/applicationsupportdirectory) | |
| - [userDomainMask](https://developer.apple.com/documentation/foundation/filemanager/searchpathdomainmask/1408037-userdomainmask) | |
| - [`UserDefaults`](https://developer.apple.com/documentation/foundation/userdefaults) | |
| - [`documentDirectory`](https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/documentdirectory) | |
| - [`applicationSupportDirectory`](https://developer.apple.com/documentation/foundation/filemanager/searchpathdirectory/applicationsupportdirectory) | |
| - [`userDomainMask`](https://developer.apple.com/documentation/foundation/filemanager/searchpathdomainmask/1408037-userdomainmask) |
cpholguera
reviewed
Jan 30, 2025
| title: Data Stored in Private Storage - Content Comparison Test | ||
| id: MASTG-TEST-0x52-1 | ||
| type: [dynamic] | ||
| weakness: MASWE-0006 |
There was a problem hiding this comment.
Please add best-practices: for all these tests, they will be similar if not the same I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2929.
I split this test into 3: