Bugfix: menuShouldBlockScroll now applies the correct right-padding

[robxbob]

Bug Description

When menuShouldBlockScroll=true, the right padding for the body tag is computed. This is to account for the right scrollbar disappearing when this prop is set. However, it computes this new right padding by accounting for any right padding applied through the styles prop; this doesn't take into account for right padding added from classes.

Bug Example

An example of the bug can be seen here where a class based right padding is applied using tailwind:
https://codesandbox.io/p/devbox/react-select-v5-sandbox-forked-fckm5s
Opening and closing the select will cause a shift in padding due to incomplete padding extraction.

Solution

https://codesandbox.io/p/devbox/react-select-v5-sandbox-forked-qnd3sz?workspaceId=ws_CRHnC6VmWcMy6krqXNjCPZ

• window.getComputedStyle is used to get the final computed right padding which accounts for padding from a class or style.
• Removed the floating paddingRight property from STYLE_KEYS as we are no longer using this style anywhere in the code.

Closes

#5342

[changeset-bot]

⚠️ No Changeset found

Latest commit: d24cf33

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.