Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-empty-model rule shouldn't warn on record models #1866

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

no-empty-model rule shouldn't warn on record models #1866

wants to merge 6 commits into from
+20 −2

Conversation

AlitzelMendez
Copy link
Member

issue: #1710

@AlitzelMendez AlitzelMendez linked an issue Nov 14, 2024 that may be closed by this pull request
no-empty-model rule shouldn't warn on record models #1710
Open
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 14, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - fix ✏️

Fix the no-empty-model rule to prevent it from being triggered for Records, as this is already covered by another rule.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez marked this pull request as ready for review November 14, 2024 18:46
@markcowl markcowl self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl requested changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@markcowl markcowl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-empty-model rule shouldn't warn on record models
3 participants
@AlitzelMendez @azure-sdk @markcowl