Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update terraform owner-contribution-flow.md #761

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Update terraform owner-contribution-flow.md #761

wants to merge 2 commits into from

Conversation

JFolberth
Copy link

Adding call out to update the README after creating the repository off the AVM template.

Overview/Summary

Adding call out to update README after leveraging AVM Template

This PR fixes/adds/changes/removes

  1. Additional step in the Terraform Owner Documentation

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@JFolberth
Update owner-contribution-flow.md
e070f22 
Adding call out to update the README after creating the repository off the AVM template.
@JFolberth JFolberth requested a review from a team as a code owner March 21, 2024 13:22
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Mar 21, 2024
@eriqua eriqua changed the title Update owner-contribution-flow.md Update terraform owner-contribution-flow.md Apr 21, 2024
@segraef segraef changed the title Update terraform owner-contribution-flow.md feat: Update terraform owner-contribution-flow.md Apr 23, 2024
@matebarabas
Copy link
Contributor

Please also address all issues identified by the linter. Thanks!

@matebarabas matebarabas added Type: Documentation 📄 Improvements or additions to documentation Language: Terraform 🌐 This is related to the Terraform IaC language and removed Needs: Triage 🔍 Maintainers need to triage still labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segraef segraef segraef requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JFolberth @matebarabas @segraef