Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p4nth3r.world Twitch Login #107

Open
Gramok opened this issue Aug 22, 2024 · 2 comments
Open

p4nth3r.world Twitch Login #107

Gramok opened this issue Aug 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Gramok
Copy link

Gramok commented Aug 22, 2024

Hi,

logged in to p4nth3r.world a few days ago (via Twitch login).

Visiting the manual directly, the Website says I'm still logged in (shows my Twitch avatar and Log out).

Switching to inventory via menu and I'm logged out (Avatar gone, button changing to Log in).

Happened a few times since I started playing, not sure if it's only when using the manual page as entry to p4nth3r.world

@whitep4nth3r whitep4nth3r added the bug Something isn't working label Aug 22, 2024
@whitep4nth3r
Copy link
Owner

Yeah I only do a check on the inventory for valid authentication. I can do it on every page to make it more consistent. Thanks for reporting!

@whitep4nth3r
Copy link
Owner

More info:

  • we check for a valid Twitch session via token in the backend when navigating to /inventory

  • every four hours (or so), the backend returns a 401 even though the front end session is "still valid"

  • when a player navigates to /inventory and gets a 401, they are logged out and redirected to the home page

  • without a standalone "auth check" endpoint for Twitch, we can't really adopt the same mechanism on all routes

  • I don't want a standalone "auth check" endpoint for Twitch to run on every page, because the API is slow and is already causing some slowdown issues in some backend endpoints

In the words of @yoshivb:

All of this is a lot of work to solve a problem thats just "sometimes i have to press to login button again"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants