Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[results-processor] Improve logging/security of secrets access from the results-processor #4044

Open
gsnedders opened this issue Oct 10, 2024 · 0 comments
Labels

Comments

@gsnedders
Copy link
Member

Accessing secrets to the results-processor is being added in #4025; see https://github.com/web-platform-tests/wpt.fyi/pull/4025/files#r1786456351 for discussion here.

Ideally we'd have both:

  • better guarding of accessing this (but ideally without entirely tying the processor module to the Flask front-end, as @main._internal_only would imply — which also would add a circular import), and
  • more detailed logging as to what exactly is accessing the secrets (run_id, uploader would be obvious — or maybe we should do this for all logging from the processor via a LoggerAdapter?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant