Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await-interactions rule not working, but others do (from 'plugin:storybook/recommended') #153

Open
paroxyzm opened this issue Apr 3, 2024 · 0 comments

Comments

@paroxyzm
Copy link

paroxyzm commented Apr 3, 2024

Describe the bug
Enabling the plugin makes some rules work, except await-interactions

To Reproduce
[use reproduce repo]

  1. Install the plugin following docs
  2. enable the plugin in .eslintrc.js extends: ['plugin:@nx/react', 'plugin:storybook/recommended'],
  3. Tweak the eslint overrides to see if any rules apply - they do (except await-interactions), see screenshots
{
  "overrides": [
    {"rules": {
        'storybook/hierarchy-separator': 'error',
        'storybook/await-interactions': 'error',

I was able to do semi-debugging locally, and when I remove the if condition in 'Program:exit' call, the plugin works as expected.

Expected behavior
Missing awaits should be marked by eslint

Screenshots
Proof that the recommended plugins are working at least partially for hierarchy-separator
image

Local tweaking: (in node_modules/await-interactions.js)
image

Plugin works after local tweaking:
image

Any ideas on how to resolve/further debug the issue would be appreciated!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant