Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comprehensive equality specs #1418

Open
nex3 opened this issue Jun 28, 2019 · 1 comment
Open

Add comprehensive equality specs #1418

nex3 opened this issue Jun 28, 2019 · 1 comment

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 28, 2019

Currently, specs for value equality (like most specs) are spread haphazardly throughout the repo. We should organize them consciously and make sure all edge cases are being tested. Equality specs for each kind of value should live in that value's directory (values/$type/equality.hrx), and they should share assert-equal() and assert-unequal() mixins that verify not only that the values are equal according to == but that all functions that care about equality (index() and various map functions) consider them equal as well.

@nex3 nex3 mentioned this issue Mar 3, 2020
@stof
Copy link
Contributor

stof commented Oct 31, 2020

@nex3 I think a comprehensive set of specs also need to include another kind of tests: tests about equality between different types of values (where different types are never equal, except for the empty list and the empty map).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants