Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Consistent Path Normalization Across sbom-tool #709

Open
Tracked by #693
JonDouglas opened this issue Sep 19, 2024 · 0 comments
Open
Tracked by #693

Implement Consistent Path Normalization Across sbom-tool #709

JonDouglas opened this issue Sep 19, 2024 · 0 comments
Labels
tabled We like this idea, but we are not going to action on it in the moment

Comments

@JonDouglas
Copy link
Member

There's no centralized/consistent approach across modules for path normalization to my knowledge.

IsValid seems close!

sbom-tool/src/Microsoft.Sbom.Api/Filters/DownloadedRootPathFilter.cs

Line 49 in ae8c3c3

public bool IsValid(string filePath)

We should implement this to any files/functions handling paths with some path normalization logic to ensure they are managed uniformly and add tests to validate that.
@JonDouglas JonDouglas mentioned this issue Sep 19, 2024
Open
13 tasks
@sfoslund sfoslund added the needs triage Default status upon issue submission label Sep 19, 2024
@jalkire jalkire added tabled We like this idea, but we are not going to action on it in the moment and removed needs triage Default status upon issue submission labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tabled We like this idea, but we are not going to action on it in the moment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JonDouglas @jalkire @sfoslund