Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10x content not visible until pop-out #264

Closed
maikelvallinga opened this issue May 19, 2020 · 6 comments
Closed

10x content not visible until pop-out #264

maikelvallinga opened this issue May 19, 2020 · 6 comments
Assignees

Comments

@maikelvallinga
Copy link

When i open the 10x window it does not show any content except buttons. So i am not able to see the app-db for example.

When i pop out the screen the content is displaying correctly and i can see the app-db. Problem occurs within Safari and Chrome.

Example with just the 10x window open:
Screenshot 2020-05-19 at 10 30 02

Example when i pop out the window:
Screenshot 2020-05-19 at 10 30 21

@whmountains
Copy link

I have a similar problem. My app dispatches :initialize-db on startup, but that is not shown in re-frame until I pop out. Then it suddenly appears.

@superstructor superstructor added this to the v1.1.0 milestone Mar 29, 2021
@superstructor
Copy link
Contributor

I cannot reproduce this issue in the example todomvc app, although the last comment on not rendering the first event on startup sounds suspiciously similar to #263

@bpringe
Copy link

bpringe commented Jun 30, 2022

This is happening to me as well. I tried in Chrome and Brave (Chromium based).

Edit: I realized the issue doesn't happen if I use dispatch instead of dispatch-sync. Related: #154 (I found this through the linked issue, #302). I'm just mentioning for anyone else reading this.

@superstructor
Copy link
Contributor

@MawiraIke are you able to reproduce ?

@MawiraIke
Copy link
Contributor

Yes @superstructor I can reproduce this issue in a new repo with only the initialize-db event. For example, I can reproduce it when I create a new re-frame project with lein new re-frame and add re-com and 10x. I also can't reproduce the issue in the todomvc app as you mentioned.
Fair to note that @bpringe solution fixes this problem. That is using dispatch instead of dispatch-sync shows the events and db when the page loads. I think this delay might be related to dispatch-sync. Hovering the mouse on some components (like the v-box drag-bar for example) also seems to make the db catch up with the latest event.

@kimo-k
Copy link
Contributor

kimo-k commented Dec 7, 2023

dispatch-sync problem is solved for #263 and #151.

I'm running the repro on the same lein template, but I don't see the original behavior reported by @maikelvallinga regarding the popout window. Looking at the code, there's nothing explicitly happening with the popout window to start or stop trace.

A problem does remain, but it's more of a feature, I think: trace doesn't run unless the panel is open.

I've added a new setting to control this. Now, you can choose for 10x to trace your app:

  • when the panel is open (default)
  • always (even when the panel is closed. when you do open it, all the trace will be there.)
  • never (immediately kills all trace)

@kimo-k kimo-k closed this as completed in e6e342c Dec 7, 2023
kimo-k added a commit that referenced this issue Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants