Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The documentation for babel-plugin-polyfill-corejs3 seems to have an error description? #164

Open
1 task
limingcan562 opened this issue May 8, 2023 · 1 comment

Comments

@limingcan562
Copy link

limingcan562 commented May 8, 2023

💻

  • Would you like to work on a fix?

How are you using Babel?

babel-loader (webpack)

Input code

import 'core-js/stable';

Configuration file name

No response

Configuration

const presets = [
    [
        '@babel/preset-env',
        {
            targets: 'ie 11',
        }
    ]
]
const plugins = [
    [
        'babel-plugin-polyfill-corejs3',
        {
            method: "entry-global", 
            version: require("core-js/package.json").version
        }
    ],
    '@babel/plugin-transform-runtime',
];
module.exports = {plugins, presets};

Current and expected behavior

  • When the value of version is the latest version of core-js (require("core-js/package.json").version), the compiled code is injected with 224 lines.

    require("core-js/modules/es.symbol.js");
    ...
    require("core-js/modules/web.url-search-params.size.js");
  • When I change the version to 3.20, the compiled code is injected with 208 lines.

    require("core-js/modules/es.symbol.js");
    ...
    require("core-js/modules/web.url-search-params.js");

Hello, I am migrating from the old configuration method to the new one.

I see from the documentation

This option only has an effect when used alongside "method": "usage-global" or "method": "usage-pure".

that version only works if you use "method": "usage-global" or "method": "usage-pure".

But when I changed the value of version, I found that it worked. So the version configuration item also acts on "method": "entry-global"?

Environment

System:
OS: macOS 12.2.1
Binaries:
Node: 14.18.1 - /usr/local/bin/node
npm: 6.14.15 - /usr/local/bin/npm
npmPackages:
@babel/cli: ^7.21.0 => 7.21.0
@babel/core: ^7.21.4 => 7.21.4
@babel/plugin-transform-runtime: ^7.21.4 => 7.21.4
@babel/preset-env: ^7.21.4 => 7.21.4
@babel/runtime-corejs3: ^7.21.5 => 7.21.5
babel-loader: ^9.1.2 => 9.1.2
babel-plugin-polyfill-es-shims: ^0.8.0 => 0.8.0
babel-plugin-polyfill-regenerator: ^0.4.1 => 0.4.1
webpack: ^5.81.0 => 5.81.0

Possible solution

No response

Additional context

No response

@babel-bot
Copy link

Hey @limingcan562! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@limingcan562 limingcan562 changed the title [Bug]: babel-plugin-polyfill-corejs3 using 'entry-global' causes the volume of the package to become larger? [Bug]: 'mtehod: entry-global' outputs larger bundle sizes than 'useBuiltIns: entry' May 9, 2023
@limingcan562 limingcan562 changed the title [Bug]: 'mtehod: entry-global' outputs larger bundle sizes than 'useBuiltIns: entry' [Bug]: 'method: entry-global' outputs larger bundle sizes than 'useBuiltIns: entry' May 9, 2023
@limingcan562 limingcan562 changed the title [Bug]: 'method: entry-global' outputs larger bundle sizes than 'useBuiltIns: entry' [Bug]: The documentation for babel-plugin-polyfill-corejs3 seems to have an error description? May 13, 2023
@nicolo-ribaudo nicolo-ribaudo transferred this issue from babel/babel May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants