Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks should be able to use itself as a child block target in schemas #754

Open
aswamy opened this issue Feb 4, 2025 · 1 comment
Open
Labels
area:language-server Bug Something isn't working good first issue Good for newcomers SEV-3 Normal Severity

Comments

@aswamy
Copy link
Contributor

aswamy commented Feb 4, 2025

Describe the bug

  • Block type completion should not allow itself as a completion option

  • Theme check should warn us when we try to use a block within itself

  • Bonus: Should we also warn when we see a circular block dependency?

Source
Image

Expected behaviour

  • blocks and presets.[].blocks.[].type should not include itself as an option
  • theme check should warn us when a block uses itself as a child block in its schemas

Actual behaviour

  • vscode completion offers the block itself as an option
  • no theme check error
@aswamy aswamy added area:language-server good first issue Good for newcomers SEV-3 Normal Severity Bug Something isn't working labels Feb 4, 2025
@aswamy
Copy link
Contributor Author

aswamy commented Feb 10, 2025

@charlespwd This is the circular issue i was talking about. Should i just close this since we should be able to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:language-server Bug Something isn't working good first issue Good for newcomers SEV-3 Normal Severity
Projects
None yet
Development

No branches or pull requests

1 participant