You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behaviour "disabled": true is reported as invalid.
Theme Check flags a more useful error.
For what it's worth while I think this should be flagged as invalid, it is actually accepted by the platform, despite being useless.
Actual behaviour
The entire "blocks" value under the "Preset" preset throws an ValidSchema error with the message in the screenshot
Debugging information
OS: macOS
OS Version: Sequoia 15.2
Theme Check Version: Unknown, according to CLI. I have @shopify/[email protected] installed though so whichever version is used by that
The text was updated successfully, but these errors were encountered:
david-w-shopify
changed the title
ValidSchema reports incorrect validation error when block is preset is disabledValidSchema reports incorrect validation error when block in preset is disabled
Jan 31, 2025
After chatting with David a bit I think there is a bug here. It's treating any non-valid attribute as a schema error (good!) but bubbling it up to a parent issue. We'll take a look at this.
Describe the bug
I'm copying some json from a template over to some schema presets and getting a theme check
ValidSchema
error with the wrong message.Source
Expected behaviour
"disabled": true
is reported as invalid.Theme Check flags a more useful error.
For what it's worth while I think this should be flagged as invalid, it is actually accepted by the platform, despite being useless.
Actual behaviour
The entire "blocks" value under the "Preset" preset throws an
ValidSchema
error with the message in the screenshotDebugging information
@shopify/[email protected]
installed though so whichever version is used by thatThe text was updated successfully, but these errors were encountered: