Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Animations Broken #2943

Open
1 task
nathan-ahn opened this issue Feb 5, 2025 · 5 comments
Open
1 task

Web Animations Broken #2943

nathan-ahn opened this issue Feb 5, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@nathan-ahn
Copy link
Contributor

Description

Looks like web animations are broken on the newest version. I don't know the exact version this bug was introduced in, but I can confirm that our web animations were working in v1.7.6. As far as I can tell, this affects all Skia animations using Reanimated.

Expected: Blue square in reproduction slides back and forth.
Actual: Blue square in reproduction does not move.

React Native Skia Version

1.11.4

React Native Version

React Native Web: 0.19.12

Using New Architecture

  • Enabled

Steps to Reproduce

https://github.com/nathan-ahn/skia-web-animation-bug

Reproducing

  1. Install yarn install
  2. Run web yarn web
  3. See the blue square (Skia) not move
    (Pink square included to demonstrate Reanimated is working)

Notes

I usually prefer to use Expo for minimum reproducible examples but can't until #2914 is resolved. I'm using the same Solito setup to that we use in production to get Skia web to work. I don't believe that any of the Next.js workarounds are causing this issue, but happy to reproduce using Expo Router once #2914 is fixed.

Snack, Code Example, Screenshot, or Link to Repository

https://github.com/nathan-ahn/skia-web-animation-bug

@nathan-ahn nathan-ahn added the bug Something isn't working label Feb 5, 2025
@nathan-ahn
Copy link
Contributor Author

If it helps with debugging, our Storybook usage of Skia animations is reporting the following error: "x" is read-only (where x is a shared value). I haven't been able to reproduce the error in Next.js.

@wcandillon
Copy link
Contributor

wcandillon commented Feb 6, 2025 via email

@nathan-ahn
Copy link
Contributor Author

For sure! I'll see if I can get a simpler minimum reproducible example, since Solito is a bit heavy for just an example. Ideally, I think it'd make most sense to have an Expo Router example (assuming this issue exists in Expo Router as well). However, Skia is currently broken in Expo Router due to #2914 (which I guess is another great reason for us to have it in apps).

Once I get the chance this afternoon, I'll create an Expo Router minimum reproducible app in apps to guard against both this issue and #2914 in the future. If this issue isn't reproducible in Expo Router, then I'll resort to likely a Solito or pure React Native Web reproduction of this animation bug.

@wcandillon
Copy link
Contributor

wcandillon commented Feb 6, 2025 via email

@nathan-ahn
Copy link
Contributor Author

Created Expo Router demo in #2949! Holding off on Solito unless absolutely necessary for reproducibility, since Solito is quite complex and can be difficult to maintain as an example. (+ Expo Router is actually mentioned in the docs for web support).

This was referenced Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants