Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing unit tests in Feign core #2752

Open
trumpetinc opened this issue Jan 31, 2025 · 0 comments
Open

Failing unit tests in Feign core #2752

trumpetinc opened this issue Jan 31, 2025 · 0 comments

Comments

@trumpetinc
Copy link

I'm running Feign Core unit tests on Windows platform, Java SE 21 (OpenJDK) and finding test failures.

These two appear to be actual functional problems:

  1. feign.DefaultContractInheritanceTest.overrideParameterizedApiSupported()
  2. feign.DefaultContractInheritanceTest.multipleInheritanceDoneCorrectly2()

Both failures look like this:

java.lang.IllegalStateException: Method OverrideParameterizedApi#get(String) not annotated with HTTP method type (ex. GET, POST)
Warnings:

  • Class OverrideParameterizedApi has no annotations, it may affect contract Default
    at feign.Util.checkState(Util.java:121)
    at feign.Contract$BaseContract.parseAndValidateMetadata(Contract.java:117)
    at feign.Contract$BaseContract.parseAndValidateMetadata(Contract.java:71)
    at feign.DeclarativeContract.parseAndValidateMetadata(DeclarativeContract.java:40)
    at feign.DefaultContractInheritanceTest.overrideParameterizedApiSupported(DefaultContractInheritanceTest.java:88)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

Less important, but all 3 tests in this test unit are failing:

  1. feign.MultipleLoggerTest

Failure is: org.junit.platform.commons.JUnitException: Failed to close extension context

I believe that these 3 failures are because JUL is grabbing file locks, which prevents JUnit from cleaning up it's temp folders under Windows. One solution would be to add a close() method to JavaLogger...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant