-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreateService Session closes on failed create #52
Comments
valentinedwv
added a commit
that referenced
this issue
Apr 15, 2016
Messages different on Mac. Single word for searching, and lower case compares
valentinedwv
added a commit
that referenced
this issue
Apr 15, 2016
Messages different on Mac. Single word for searching, and lower case compares
Digging (looking into random failures)
Then all Service classes need to use getSession(), rather than self._session |
This is from the turned on test_odm2.py/test_sessionNotFailed
|
I think we will need to do a try-exception block, with session.rollback if things do not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Adding tests based on @Castronova branch, and seeing that if a constraint is invalid, that the session becomes invalid.
Need to see check is the session is still open before attempting to create.
The text was updated successfully, but these errors were encountered: