Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for key vault references #52

Open
1 task done
epa095 opened this issue Feb 4, 2024 · 2 comments · Fixed by #55 · May be fixed by #67
Open
1 task done

Support for key vault references #52

epa095 opened this issue Feb 4, 2024 · 2 comments · Fixed by #55 · May be fixed by #67

Comments

@epa095
Copy link

epa095 commented Feb 4, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

Its possible to have secrets based on a key-vault reference, https://learn.microsoft.com/en-us/azure/container-apps/manage-secrets?tabs=arm-template#reference-secret-from-key-vault

But can it be done with this module?

I tried the following, but then it complained that I need "value". If I put the keyvault URI in the value, then the URL itself becomes the secret.

  container_app_secrets = {
    nginx= [
      {
        name        = "secret"
        keyVaultUrl = "https://somethingvault.azure.net/secrets/thesecret"
        identity    = "system"
      }
    ]
  }

New or Affected Resource(s)/Data Source(s)

N/A

Potential Terraform Configuration

No response

References

https://learn.microsoft.com/en-us/azure/container-apps/manage-secrets?tabs=arm-template#reference-secret-from-key-vault

@lonegunmanb
Copy link
Member

Thanks @epa095 for opening this pr! I've checked the provider's schema, we need add KeyVaultUrl support there first.

I'll open a pr to the provider's repo.

@matthew-patrick
Copy link

It looks like it was implemented into tf provider. Is there an anticipated timelike for when this can be implemented into the module as well as a documentation update?

@lonegunmanb lonegunmanb linked a pull request Nov 15, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants